Ensure context is passed through when calling get_serializer#44
Open
jamesfneyer wants to merge 2 commits intomasterfrom
Open
Ensure context is passed through when calling get_serializer#44jamesfneyer wants to merge 2 commits intomasterfrom
get_serializer#44jamesfneyer wants to merge 2 commits intomasterfrom
Conversation
mlclay
suggested changes
Oct 26, 2020
Contributor
mlclay
left a comment
There was a problem hiding this comment.
Please use the same logic the upstream repository used to handle this new functionality: encode/django-rest-framework#7298
Contributor
Author
|
I originally did it this way so that the default context would not be overwritten, but instead expanded. |
mlclay
approved these changes
Oct 26, 2020
Contributor
mlclay
left a comment
There was a problem hiding this comment.
LGTM
Thanks for the update for context precedence parity with upstream. I'd like this to not deviate too far from the expected DRF ViewSet functionality where we can manage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling
get_serializeronConfigurableGenericViewSet, ensure thatcontextis passed through, and not overwritten by theget_serializer_contextin the defaultget_serializer.