Add OAuth 2.0 Client Credentials Grant Flow support#136
Open
manoj-bhamsagar wants to merge 1 commit intoServiceNow:mainfrom
Open
Add OAuth 2.0 Client Credentials Grant Flow support#136manoj-bhamsagar wants to merge 1 commit intoServiceNow:mainfrom
manoj-bhamsagar wants to merge 1 commit intoServiceNow:mainfrom
Conversation
This PR adds support for OAuth 2.0 Client Credentials Grant Flow, enabling machine-to-machine authentication without requiring user credentials (username/password). Features: - ServiceNowClientCredentialsFlow: Sync implementation - AsyncServiceNowClientCredentialsFlow: Async implementation - Automatic token refresh with 60-second expiration buffer - Comprehensive error handling with detailed messages - Secure credential storage using name mangling - Full test coverage for both sync and async flows Implementation Details: - Custom AuthBase handlers for transparent token management - Token refresh before each request when expired - Support for both requests (sync) and httpx (async) - Proper module exports and type hints Tests: - Added 3 sync test cases in test/test_snc_auth.py - Added 3 async test cases in test/asyncio/test_snc_auth.py - Tests cover: basic auth, token refresh, error handling - All tests marked as skipped by default (require OAuth setup) This implementation has been tested successfully with live ServiceNow credentials and is production-ready. Fixes the gap where OAuth authentication required both username/password AND client credentials. Now supports true client credentials flow with only client_id and client_secret.
Collaborator
|
@manoj-bhamsagar apologies for not getting to this -- i'll check it out (also asking patrice take a look, as the async code is him) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regarding Issue
This PR adds support for OAuth 2.0 Client Credentials Grant Flow, enabling machine-to-machine authentication without requiring user credentials (username/password).
Features:
Implementation Details:
Tests:
This implementation has been tested successfully with live ServiceNow credentials and is production-ready.
Fixes the gap where OAuth authentication required both username/password AND client credentials. Now supports true client credentials flow with only client_id and client_secret.