Add SoftLimit field to FeatureEntitlement and improve desc tags#21
Merged
Add SoftLimit field to FeatureEntitlement and improve desc tags#21
Conversation
dontlaugh
approved these changes
Feb 4, 2026
Comment on lines
+138
to
+139
| CreditTotal *float64 `json:"credit_total" desc:"If the company has a credit-based entitlement for this feature, the total credit amount"` | ||
| CreditUsed *float64 `json:"credit_used" desc:"If the company has a credit-based entitlement for this feature, the amount of credit used"` |
Contributor
There was a problem hiding this comment.
CreditTotal and CreditUsed are also always-unset (for now).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We discussed soft limit as an omission when doing this original work, but its needed now for another ticket. I will add the code on the api side to fill this in.
Also, I had made some improvements to these desc tags that I never checked in. Some of them don't really make sense (referencing "rules" when they're not used in a rules context), I think these are better.