Fix Webpack Hot Reload error (issue #3):#7
Open
morrow wants to merge 1 commit intoSalesLoft:masterfrom
Open
Conversation
Update webpack configuration to specify output.publicPath with webpack port loaded from dotenv. Update index to allow for re-rendering application on hot-reload. Include NamedModulesPlugin to provide module names instead of numbers.
morrow
force-pushed
the
fix-hot-reload
branch
from
287e64c to
5b0b78a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Made:
Explanation:
The current bug is caused by webpack trying to retrieve hot-update.json data from localhost:5000/hot-update.json instead of localhost:5001/hot-update.json. This is fixed by updating the webpack configuration with a output.publicPath variable with the correct port number, retrieved using dotenv. Additionally, module.hot.accept and a renderApp function are added to index.js to re-render the app when changes are detected.
See: https://medium.com/@dan_abramov/hot-reloading-in-react-1140438583bf
Before:
... make some changes to client code ...
After:
... make some changes to client code ...