[WIP-draft] Multi quarters API [do-NOT-merge]#53
Open
jorgemarpa wants to merge 5 commits intoSSDataLab:masterfrom
Open
[WIP-draft] Multi quarters API [do-NOT-merge]#53jorgemarpa wants to merge 5 commits intoSSDataLab:masterfrom
jorgemarpa wants to merge 5 commits intoSSDataLab:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR shows how to adapt the API to work with multi-quarter TPFS of the same sky group, e.g. TPFs of Kepler quarter 1, 5, 9.
It includes a custom multi-quarter method (
_parse_multi_quarter_TPFs) that uses masks to find shared TPF pixels between quarters, this is necessary because sometimes the target masks change between quarters. For now, we only used pixels that have data in all quarters, this can be improved in the future to keep pixels with missing quarters.TODO:
pd.mergemethod, this could be faster and cleaner.machineAPI to allow missing data.Note:
This PR uses #52, which adds the "segment" method to the time model fitting.