This repository was archived by the owner on Dec 4, 2021. It is now read-only.
Conversation
Added README
Added overview, client, protos, printers and struggles section. Also moved js files to client/ directory and python to server/ and protos to proto/ directory.
Added Directories + Update README
* Added README * Added an overview function in README * processed the raw bytes * processed the raw bytes
* Added README * updated README server, LPD to include raw data processed the raw bytes processed the raw bytes updated README server, LPD to include raw data
* Added Base64 Encoding to File Now, Jerry's resume is encoded in the base64 format, and is then sent to the RPC with the PrintRequest proto's encoded field. * Added Auto Generated Code to JS Client
* Moved Print Client and Server to Unique Directory We will eventually have RPCs for signs, 3D prints and maybe more. This makes the file structure more scalable. * Renamed Python and Node Files to Snake Case Follows .js and .py file name conventions.
* Moved Print Client and Server to Unique Directory We will eventually have RPCs for signs, 3D prints and maybe more. This makes the file structure more scalable. * Renamed Python and Node Files to Snake Case Follows .js and .py file name conventions. * Added LED Sign RPC Consists of a client, server and proto file.
* made print_client callable * Update client/printing/print_client.js Co-Authored-By: Evan Ugarte <36345325+evanugarte@users.noreply.github.com> * Update print_client.js Co-authored-by: Evan Ugarte <36345325+evanugarte@users.noreply.github.com>
* added package and setup * added setup.sh
Also added documentation for parameters and return values.
We now can await on the call and use .then() and .catch() for handling RPC responses.
Now, we won't show the IP address on github and take an L.
Takes the number of copies into account to determine which printer goes
* Add Setup .bat File Resolves #17 Co-authored-by: Jerry Lee <jerrylee1157@gmail.com>
* need to auto generate py files * need to auto generate py files * 3d RPC and encoder/decoder * ??? * hopefully removed node_modules * resolve pr * resolve pr
* print client returns promise * Made printer return promise
This involved changing the version number and repo name in the file. Now we can properly generate a package-lock.json from it with npm install.
* Added AddMessageToQueue and ClearMessageQueue RPC and regenerated python files * Removed exe file and fixed client and server files * Fixed merge conflict Co-authored-by: Nanar Boursalian <nanar.boursalian01@gmail.com>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Destination is no long used in the front end -- Force pushed this as it literally changes 1 line
* Adds routes and tests for PrinterHealthCheck * Regenerated client and server files for Printer Health Check RPC
3a7f0bb to
16a4e1c
Compare
16a4e1c to
59882df
Compare
law-nguyen
approved these changes
Apr 13, 2021
Collaborator
law-nguyen
left a comment
There was a problem hiding this comment.
Looks good! Address the comments I made (nothing major) and should be good to go
Comment on lines
+20
to
+30
| // function getBase64Image(img) { | ||
| // let canvas = document.createElement('canvas'); | ||
| // canvas.width = img.width; | ||
| // canvas.height = img.height; | ||
| // let ctx = canvas.getContext('2d'); | ||
| // ctx.drawImage(img, 0, 0); | ||
|
|
||
| // let dataURL = canvas.toDataURL('image/png'); | ||
|
|
||
| // return dataURL.replace(/^data:image\/(png|jpg);base64,/, ''); | ||
| // } |
Collaborator
There was a problem hiding this comment.
make sure to remove these :)
|
|
||
| class FaceImageServicer(aws_rekognition_pb2_grpc.FaceImageServicer): | ||
| def RequestFaceCoordinate(self, request, context): | ||
| print('we got something') |
Collaborator
There was a problem hiding this comment.
I would get rid of the debug statements as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rpc side of doing facial recognition of the image.
basic functionality :
of the face in the original image.