Light Calorimetry (Production)#911
Open
lynnt20 wants to merge 89 commits intoproduction/sbnd-gen2from
Open
Conversation
Version v09_67_00
- cleaned (but need to clean more) skipping products that aren't used (xarapuca flashes + truth products) for example to avoid nullptr
- cleaned (but need to clean more) skipping products that aren't used (xarapuca flashes + truth products) for example to avoid nullptr
- moved truth validation to a separate function - added lower/upper threshold for PE per channel - added fcl param to turn on/off evaluating all planes - option to add dir/refl efficiencies; NOTE: not really accounted for in the code yet
- merge the two previous trees into one - match-type can now differentiate between event/slice level easily
Version v09_89_01, patch release for SBN2024A
Version v09_93_01_02p02
Version v10_04_07
…, generic clean up
Version v10_14_02
…ask; add upper limit to avoid nonlinearity effects (rough idea)
…ghted avg fix - BCFM has at most, one bcfm<->one slice <-> one opflash association, even if there are opflashes in both tpcs. Explicitly look for an opflash (within a fcl parameter window) in the opposite TPC if the slice has spacepoints in both TPCs - bug fix for weighted average; need to treat each TPC as independent for calculating the weighted avg
…ghted avg fix - BCFM has at most, one bcfm<->one slice <-> one opflash association, even if there are opflashes in both tpcs. Explicitly look for an opflash (within a fcl parameter window) in the opposite TPC if the slice has spacepoints in both TPCs - bug fix for weighted average; need to treat each TPC as independent for calculating the weighted avg
- add to standard mc/data reco2 workflow - add SCE tag to cafmaker sce for data and mc
…ctable PMTs (use pmt calib db instead)
…to some fcl comments - also remove unused functions
…ing messages; avoid hardcoded TPC tick
This reverts commit 6ff86f1.
…e data fcl configuration
Version v10_14_02_01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Identical to #878.
Checklist
Reviewers,AssigneesDevelopementRelevant PR links
Accompanying PRs: SBNSoftware/sbncode#619, SBNSoftware/sbnanaobj#181, SBNSoftware/sbnobj#158
Link(s) to docdb describing changes (optional)
Is there a docdb describing the issue this solves or the feature added?