Open
Conversation
henrylay97
approved these changes
Feb 5, 2026
Member
henrylay97
left a comment
There was a problem hiding this comment.
Thanks for doing this so quickly @AndyChappell!
Looks great to me, I have one request - could you put a comment line in the top of the Master XML that directs people editing it to make the same edits to the CI XML? Might prevent the future divergence you mention 😄
Contributor
Author
|
Done |
Contributor
|
Tagging @SabrinaBrickner and @vitodb since it is a CI related PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds new fcl and Pandora XML configurations to support direct production of Pandora metrics within the continuous integration system. Provisionally, these contain a number of basic cluster metrics (ARI, purity, completeness, etc), but could in principle be extended in the future.
The ci_reco2_sbnd.fcl inherits from standard_reco2_sbnd.fcl and makes the minimal changes to the Pandora configuration for this workflow to run. The PandoraSettings_CI_SBND.xml mirrors the current PandoraSettings_Master_SBND.xml. Unfortunately, because this can't inherit a workflow, so it will be necessary to ensure suitable syncrhonisation between the CI XML and the standard Master XML if the Master XML changes (the CI XML removes the visualisation algorithms and adds the cluster validation algorithm). However, the Master XML is the most stable part of the configuration, and so changes here should be relatively rare.
Checklist
Reviewers,AssigneesDevelopement