Generic filter module for exclusive cross section sample production#904
Draft
Generic filter module for exclusive cross section sample production#904
Conversation
afropapp13
approved these changes
Feb 3, 2026
afropapp13
left a comment
There was a problem hiding this comment.
Many thanks for all the work, happy with the filter!
Contributor
|
Hi @tbwester This filter looks incredibly useful, and its usefulness extends beyond SBND. I think this should live in LArSoft, so that other experiments can make use of it (I can already think of some usecases). The filter could live alongside a LArG4 filter I wrote years ago: https://github.com/LArSoft/larevt/blob/52fa202b71b6186ccc54522651107e9ea7a5724e/larevt/Filters/LArG4ParticleFilter_module.cc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Filter module that is configurable for specifying common requirements for cross section signal definitions. This PR is a draft since other options may need to be added.
Features:
Some example signal definition configurations are added to
fcls/signal_filters_sbnd.fcl.Checklist
Reviewers,AssigneesDevelopement