MC PMT Software Trigger + Trigger Subdirectory Reorganization

[lynnt20]

Description

Add MC version of PMT Software Trigger, add data PMT Software Trigger (equivalent to DAQ version) and reorganize the Trigger subdirectory in order to differentiate between legacy hardware+software PMT trigger simulation and current PMT software trigger simulation/development. All current PMT Metric modules (producers, filter, and analyzers) have now been moved to Trigger subdirectory PMTSoftware.

detsim and cafmaker fcls have been updated to run/accept PMT software trigger inputs/outputs.
CAF maintainers have been added as reviewers for the accompanying PRs in sbncode and sbnanaobj.

PMTMetricProducer.cc

Replica of sbndaq-artdaq/ArtModules/SBND/SoftwareTrigger/PMTMetricProducer_module.cc. The version in sbndaq-artdaq cannot be called in sbndcode since DAQ repos are not generally available through UPS, and vice versa.

PMTMCMetricProducer.cc

First-pass at replicating software trigger in data. Inputs are raw::OpDetWaveform. Module simply takes 10 us chunk of optical waveforms from the PMTs and sums them into a "flash".

Checklist

• Added at least 1 label from available labels.
• Assigned at least 1 reviewer under Reviewers,
• Assigned all contributers including yourself under Assignees
• Linked any relevant issues under Development
• Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
• Does this affect the standard workflow?
• [N/A] Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

Relevant PR links (optional)

Should go in with SBNSoftware/sbnanaobj#174, SBNSoftware/sbncode#604, but building sbndcode shouldn't depend on these PRs.

Link(s) to docdb describing changes (optional)

Some discussion in docdb44316.

[fjnicolas]

Thank you for the addition @lynnt20! My main comment is whether we need to mask the PMTs that are OFF in the PMTSoftwareTrigger.

[lynnt20]

sorry @fjnicolas, I updated the producer modules and also cafmaker lables again to be consistent with Run1 labels (pmtmetricbnbzero, pmtmetricbnblight, etc.) since the main motivation is to process the Run1 data. In the future we might have to update the cafmaker fcl param to accept multiple labels!

[nathanielerowe]

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_12_02 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_12_02

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e26:prof - ignored failure for unit_test -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

[nathanielerowe]

Looks like a few config errors

2: cet::exception caught in art
3: ---- Configuration BEGIN
4:   The following error occurred while processing a path configuration:
5:   Entry with name pmtmetricmc in path simulate does not have a module configuration.
6: ---- Configuration END
7: %MSG
8: Art has completed and will exit with status 9.```

[nathanielerowe]

51: terminate called after throwing an instance of 'cet::coded_exception<fhicl::error, &fhicl::detail::translate[abi:cxx11]>'
52:   what():  ---- Parse error BEGIN
53:   detected at or near line 9, character 49, of file "/scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/build_slf7.x86_64/sbndcode/fcl/metricfilter.fcl"
54:   
55:                           "pmtmetriccrossingmuon"];
56:                                                   ^
57: ---- Parse error END
58: 
59: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbndcode/test/fcl/testFHiCLfiles.sh: line 221: 39487 Aborted                 (core dumped) $fhicldump --quiet "${Options[@]}" --config "$FHiCLpath"
60: ERROR: File '/scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/build_slf7.x86_64/sbndcode/fcl/metricfilter.fcl' failed verification (code: 134).
61: terminate called after throwing an instance of 'cet::coded_exception<fhicl::error, &fhicl::detail::translate[abi:cxx11]>'
62:   what():  ---- Parse error BEGIN
63:   detected at or near line 9, character 49, of file "/scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/build_slf7.x86_64/sbndcode/fcl/metricfilter.fcl"
64:   included from line 1 of file "/scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/build_slf7.x86_64/sbndcode/fcl/run_metricfilter.fcl"
65:   
66:                           "pmtmetriccrossingmuon"];
67:                                                   ^
68: ---- Parse error END
69: ```

[lynnt20]

@nathanielerowe sorry about that! Accidentally deleted a line when resolving merge conflicts with develop. Things should be good now!!

[nathanielerowe]

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_12_02 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_12_02

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

[nathanielerowe]

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_12_02 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbncode#604 SBNSoftware/sbnanaobj#174 SBNSoftware/sbn*@SBN_SUITE_v10_12_02

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

[nathanielerowe]

Approved pending sbn level PRs being merged