Introduce recursive shower mop-up algorithms at the end of the Pandora reconstruction#845
Open
Introduce recursive shower mop-up algorithms at the end of the Pandora reconstruction#845
Conversation
cerati
approved these changes
Sep 5, 2025
Contributor
cerati
left a comment
cerati
left a comment
There was a problem hiding this comment.
I am not an expert on the details of the pandora xml, but I definitely support adding this algorithm to the chain!
acampani
approved these changes
Sep 16, 2025
acampani
left a comment
acampani
left a comment
There was a problem hiding this comment.
I discussed the details of the inclusion of these algorithms in the chain with Dom B. and other Pandora experts from SBND and prepared the sequence that Riccardo tested and validated in extensive detail so, given the positive results of the change, I approve this PR and the inclusion of the mop up as part of Pandora reconstruction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the recursive shower mop-up algorithms (
LArRecursivePfoMopUp) towards the end of the reconstruction, after the track-shower PFP characterization. This initial implementation was agreed with reconstruction experts and SBND collaborators. The updated XML from this PR was used for all the tests performed in the past few months (e.g., SBN DocDB 39622).Review
Tagging for review: @acampani, @brucehoward-physics, @cerati.
Thanks!