Replaced link to DetectorClocksServiceStandard#824
Open
PetrilloAtWork wants to merge 2 commits intoSBNSoftware:developfrom
Open
Replaced link to DetectorClocksServiceStandard#824PetrilloAtWork wants to merge 2 commits intoSBNSoftware:developfrom
PetrilloAtWork wants to merge 2 commits intoSBNSoftware:developfrom
Conversation
…caruscode Service implementations should not be linked against.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code should not need to link to service implementations, but only to their interface.
It is art which will dynamically load the appropriate service per the job configuration.
This rule holds for services with multiple implementations (like
DetectorClocksServiceandDetectorPropertiesService) and not for simple services (likeGeometryorWireReadout).A flawed seed in a single
CMakeLists.txtlinking directly tolardata::DetectorInfoServices_DetectorClocksServiceStandard_servicehas proliferated throughouticaruscode. The correct library to link is insteadlardata::DetectorClocksService(which is not really a library, but it is what is needed nonetheless). This PR fixes all the faulty links to that service.There should be no consequences to any level.
Reviewers:
I don't know who else...