Storage of job execution environment in output files [4/4]#794
Open
PetrilloAtWork wants to merge 1 commit intoSBNSoftware:developfrom
Open
Storage of job execution environment in output files [4/4]#794PetrilloAtWork wants to merge 1 commit intoSBNSoftware:developfrom
PetrilloAtWork wants to merge 1 commit intoSBNSoftware:developfrom
Conversation
The default ROOT output configuration is updated to save the metadata into art/ROOT and TFileService output files.
PetrilloAtWork
added
enhancement
SFBayLaser
approved these changes
May 7, 2025
Contributor
SFBayLaser
left a comment
SFBayLaser
left a comment
There was a problem hiding this comment.
I am all for having this information stored in output files. I am not sure I am following all of the code details but from what I see it looks fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of the pull request SBNSoftware/sbncode#497.
All discussion goes there.