Split install action into the new crate cargo-gpu-install#132
Split install action into the new crate cargo-gpu-install#132Firestar99 merged 8 commits intomainfrom
cargo-gpu-install#132Conversation
cargo-gpu-install for just the install action, without requiring clapcargo-gpu-install
ad68f13 to
2fa2f87
Compare
| // build the shader crate | ||
| let mut builder = backend.to_spirv_builder(shader_crate, "spirv-unknown-vulkan1.2"); | ||
| // set to true when you're in a build script, false when outside one | ||
| builder.build_script.defaults = true; |
There was a problem hiding this comment.
This line is already adjusted for Rust-GPU/rust-gpu#488, even though it is not yet in this branch. So this will fail doctests (which we don't test in ci...)
cargo-gpu-installcargo-gpu-install
|
Looks good! What about adding a section in the main README about the 2 ways (as a CLI and as a crate) of using this project? I think that the only reason |
|
Kept the readme update simple: https://github.com/Rust-GPU/cargo-gpu/blob/install-crate/README.md (and updated the cargo-gpu-install readme to not mention wgsl stuff) On crossterm, yes that's the only thing we use it for. Which is why I just hid it behind the |
c2f6e16 to
e90f4b7
Compare
This comment was marked as outdated.
This comment was marked as outdated.
d6b8aa5 to
d43927a
Compare
|
Let's move the entire readme discussion to #133, since I think it needs a lot more than just mentioning the crate dependency path. (Also I hid your large comment) Primarily, I made this over the past few weeks: https://github.com/Rust-GPU/rust-gpu-template |
f7294b5 to
17596c8
Compare
d43927a to
d347e74
Compare
unintentionally started sharing the cache dir between tests
d347e74 to
851bdb8
Compare
|
My https://github.com/Firestar99/nanite-at-home project has lost 30 dependencies by switching to |
Requires #128
See primary issue #105
Superseding #112 and #117
cargo-gpu-installcrate*-cacheenv_logger,relative-path,serde_json,semver,dunceserdeis not worth feature gating, sincespirv-builderitself needsserdeandserde_jsonclose #105