send keepalives during checksum operations in daemon mode#840
Open
tenox7 wants to merge 1 commit intoRsyncProject:masterfrom
Open
send keepalives during checksum operations in daemon mode#840tenox7 wants to merge 1 commit intoRsyncProject:masterfrom
tenox7 wants to merge 1 commit intoRsyncProject:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an experimental PR that helps to prevent timeouts during file list generation with
--checksum.Even with
--timeout=xxxfar exceeding file list generation time, both client and server end up stuck atpselect6()forever. I have triedSO_KEEPALIVEand all combinations of partial/whole recursive, non-recursive, etc etc. Nothing really helps.I have NOT extensively tested it, but it resolves my issue #839.