fix: add user-friendly error notification for login failures#1107
Open
vivekyadav-3 wants to merge 1 commit intoRocketChat:developfrom
Open
fix: add user-friendly error notification for login failures#1107vivekyadav-3 wants to merge 1 commit intoRocketChat:developfrom
vivekyadav-3 wants to merge 1 commit intoRocketChat:developfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves the login UX by surfacing a clear, user-friendly error notification when login fails unexpectedly (e.g., network/server issues), instead of only logging to the console.
Changes:
- Corrected the console error message grammar from "A error occurred..." to "An error occurred..." in the
useRCAuthhook. - Added an error toast in the
useRCAuthlogin catch block using the existingdispatchToastMessageutility, with the message: "Unable to connect to server. Please check your connection and try again." - Kept existing console logging for debugging while ensuring end users receive visible feedback on connection/login issues.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently, when login fails due to network errors or unexpected server issues, users receive no feedback. The error is only logged to the console, leaving users confused about why login isn't working.
Solution
Added a user-friendly toast notification that appears when login fails unexpectedly. This provides clear feedback to users that there's a connection issue and suggests checking their network.
Changes
dispatchToastMessageutilityTesting
User Impact
Users will now see: "Unable to connect to server. Please check your connection and try again." instead of being left wondering why login failed.