fix(react): add missing unique key props to ChatInputFormattingToolba…#1102
Open
deepak0x wants to merge 1 commit intoRocketChat:developfrom
Open
fix(react): add missing unique key props to ChatInputFormattingToolba…#1102deepak0x wants to merge 1 commit intoRocketChat:developfrom
deepak0x wants to merge 1 commit intoRocketChat:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a common React warning:
The warning occurred in the
ChatInputFormattingToolbarcomponent and was caused by several elements being rendered as part of dynamic lists without providing a uniquekeyprop. This made it harder for React to correctly track and optimize updates to these elements.Closes #1098
Changes
Updated
packages/react/src/views/ChatInput/ChatInputFormattingToolbar.js:key="audio"to theAudioMessageRecordercomponent.key="video"to theVideoMessageRecordercomponent.<>) with<React.Fragment key={item.name}>for mapped formatting buttons (bold, italic, strike, etc.).