fix: resolve duplicated links when quoting multiple messages in ChatI…#1100
Open
vivekyadav-3 wants to merge 1 commit intoRocketChat:developfrom
Open
fix: resolve duplicated links when quoting multiple messages in ChatI…#1100vivekyadav-3 wants to merge 1 commit intoRocketChat:developfrom
vivekyadav-3 wants to merge 1 commit intoRocketChat:developfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where quoting multiple messages in ChatInput resulted in duplicated links. The issue was caused by mutating a shared quotedMessages variable inside the map loop, causing accumulation across iterations.
Changes:
- Refactored quote message handling to use a functional approach with
mapreturning individual links instead of mutating shared state - Renamed
quoteArraytoquoteLinksfor better clarity - Each quote now generates exactly one link, preventing duplication
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While exploring the
ChatInput
component, I noticed that quoting multiple messages led to redundant content accumulation in the message body. This was caused by a string mutation inside the quoteMessage.map loop.
I've refactored the logic to use a clean functional approach (map + join), which ensures each quote correctly generates exactly one link and improves performance