Open
Conversation
lib/Rex/Logger.pm
Outdated
Member
There was a problem hiding this comment.
Do we really need Exporter::Shiny as a new dependency? :)
321ca8a to
fa5efa8
Compare
Contributor
Author
|
lib/Rex/Logger.pm
Outdated
Member
There was a problem hiding this comment.
I'm afraid this breaks existing Rex::Logger::info calls in the wild, at least when they specified warn or error levels :/ Am I missing something? Maybe I'm mistaken, didn't test it yet.
fa5efa8 to
88b8d70
Compare
Contributor
Author
|
Updated to make call to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synopsis of changes: