feat: adding hinkal private batch payments#1627
feat: adding hinkal private batch payments#1627nkoreli wants to merge 2 commits intoRequestNetwork:masterfrom
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Directionally, this PR looks fine to me 👍 I don't know if it satisfies the requirements 🤷 Before merging, we must show that the |
Add Batch Payment Support for Hinkal Shielded Addresses
Description
This PR introduces batch payment functionality for Hinkal shielded addresses, allowing users to send multiple payments to different recipients in a single transaction. This feature improves efficiency and reduces gas costs when making multiple private payments.
Key Changes
sendBatchPaymentsToHinkalShieldedAddressesFromPublicfunction to support batch paymentsTechnical Details
multiSendPrivateRecipientsunder the hoodTesting
Added test case that verifies:
Security Considerations
Jest Configuration Change
isolatedModulesto falseisolatedModulesis true, Jest doesn't transpile dynamic import statements to CommonJS format and, as a result, Jest's VM sandbox uses experimental ES loader features which fail with our test setupisolatedModulesto false ensures proper transpilation of dynamic imports for Jest testing