Use path prefix as default prefix when loading models#28
Use path prefix as default prefix when loading models#28
Conversation
|
Need to update the CHANGELOG since this is a breaking change. Or I guess maybe we only need to do that on the next release. |
|
did this get merged? i dont see the branch in the list of remote branches? |
@bradlo this work is not yet merged, the branch is still there |
|
|
||
| * Add --prefix option to load-models | ||
| * Add get-model-source command | ||
| * Use models path as a default prefix (could be overwitten by --prefix flag) |
There was a problem hiding this comment.
what exactly is the semantic for use of paths in file names? aside from the prefix arg? eg: i assume we canonicalize paths in some way? what does ../foo/../bar/baz/model.rel do? what if its a path from home, eg: ~/bar/baz/model? and what about a fully qualified path? the original idea was to use the basename, and prepend any prefix provided by the prefix arg. simple and unambiguous. what use case does this not handle?
This PR adds the ability to the
clito use models paths as prefix by default like explained below:Models will be loaded under
path1/to/model1andpath2/to/model2prefixes.--prefixModels will be loaded under
model1andmodel2