Open
Conversation
danzen
changed the title
File renamed and link added to RFC PR.
owendwyer
reviewed
Mar 14, 2020
text/0005-stage-transforms.md
Outdated
|
|
||
| ## Drawbacks | ||
|
|
||
| This will break existing code but can be turned off to not break existing code. To update to a new version of CreateJS but keep the existing code working, the stageTransformable could be set to false: |
There was a problem hiding this comment.
To be clear about this, would it be correct to say that it will only break existing code that fixes the issue in a different way? If people are unaware of the issue or don't scale the stage, then they won't be affected at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing the stage transformation issue in CreateJS.
Just a note... this is not the RFC but rather an introductory comment. The RFC can be found by clicking the Files link above - to view the actual file open the three dots at the right and select view file. I feel like there should be a better introduction here, as this is where conversation happens but adding more details, just makes it more confusing as to the actual location of the RFC. So go find it and leave any comments below or embedded or how ever it is going to work - will get used to it soon, I suppose.