Conversation
|
No obvious timing issues in HEAD=jumpTableCastRemoval Generated via commit 600388e Download link for the artifact containing the test results: ↓ atime-results.zip
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7396 +/- ##
=======================================
Coverage 99.13% 99.13%
=======================================
Files 85 85
Lines 16610 16610
=======================================
Hits 16466 16466
Misses 144 144 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| { "Ctest_dt_win_snprintf", (DL_FUNC)&test_dt_win_snprintf, -1 }, | ||
| { "Cdt_zlib_version", (DL_FUNC)&dt_zlib_version, -1 }, | ||
| { "Cdt_has_zlib", (DL_FUNC)&dt_has_zlib, -1 }, | ||
| { "Csubstitute_call_arg_namesR", (DL_FUNC)&substitute_call_arg_namesR, -1 }, |
There was a problem hiding this comment.
This looks nice now, but if ever a new routine is added that is longer than Csubstitute_call_arg_namesR, it will induce a very large diff touching all of these lines.
So to complete this PR I would:
- put
static const **on the first line - indent the array contents by 2 spaces
And remove extra whitespace.
There are a few packages doing { "..." instead of {"...", but it's the minority. Personally I prefer {"...".

Ignore the fork name.
Just reformatting to make it more readable.