Make SchoolProject destroy dependent Transitions #667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zetter-rpf
approved these changes
Feb 3, 2026
Previously, when a SchoolProject was destroyed, there was a rule that
dependent `school_project_transitions` would be nullified rather than
destroyed.
At the same time, the definition of a `SchoolProjectTransition` states
that the `school_project_id`, which refers to the project being
transitioned, CANNOT be null.
Therefore, when PR
[#637](#637)
allowed deletion of Students and, consequently, Projects, the error in
these relations and nullification rules was exposed.
This leads to an error when deleting a Student who owns projects which
have been transitioned.
This commit changes the `dependent:` rule between SchoolProject and
SchoolProjectTransition to destroy the transition when the Proejct is
destroyed. It also adds a test to ensure this happens.
fspeirs
force-pushed
the
fs-fix-project-deletions
branch
from
c2e05be to
848f47c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an incorrect dependent: rule between SchoolProject and SchoolProjectTransition that was causing database constraint violations when deleting students who own projects with state transitions.
Changes:
- Modified the
dependent:rule from:nullifyto:destroyto properly cascade deletions - Updated the model spec to reflect the corrected dependency behavior
- Added a comprehensive test to verify transitions are deleted when projects are destroyed
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/models/school_project.rb | Changed dependent: :nullify to dependent: :destroy for school_project_transitions association |
| spec/models/school_project_spec.rb | Updated spec expectation to match the corrected dependent: :destroy rule |
| spec/services/student_removal_service_spec.rb | Added test case verifying that project transitions are properly deleted when student projects are removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an incorrect
depdendent:rule betweenSchoolProjectandSchoolProjectTransition.Status
Points for consideration:
What's changed?
Database and Model Relations and Nullify Rules
Previously, when a SchoolProject was destroyed, there was a rule that dependent
school_project_transitionswould be nullified rather than destroyed.At the same time, the definition of a
SchoolProjectTransitionstates that theschool_project_id, which refers to the project being transitioned, CANNOT be null.Therefore, when PR #637 allowed deletion of Students and, consequently, Projects, the error in these relations and nullification rules was exposed.
This leads to an error when deleting a Student who owns projects which have been transitioned.
This PR changes the
dependent:rule between SchoolProject and SchoolProjectTransition to destroy the transition when the Proejct is destroyed. It also adds a test to ensure this happens.Follow on Work
While this PR fixes the immediate problem, there remains an issue that
SchoolStudentsController#destroy_batchwill return a200status code on both success and failure. I suggest we address this in a follow up issue.Steps to perform after deploying to production
NA