Open
Conversation
ncc build
a-cong
reviewed
Mar 17, 2023
| @@ -1,46 +1,68 @@ | |||
| { | |||
| "name": "RapidAPI-testing-github-action", | |||
| "version": "1.0.0", | |||
| "lockfileVersion": 1, | |||
| "version": "0.0.3", | |||
There was a problem hiding this comment.
My suggestion, just to get start off on a normal version number. This PR does not warrant a major version change, but we probably should have started with 1.x so I figured we would just move it now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bumping dependency versions to address security vulnerabilities:
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Had issues with running the action using
node_modulesso updated the build to usenccwith the modified entry point ofdist/index.jsVerification
Ran action against this branch to trigger a test:
and executed successfully
