Conversation
All files were formatted with the command at repository root: `find ./ -iname *.h -o -iname *.cpp | xargs clang-format -i` .clang-format contents: --- Language: Cpp BasedOnStyle: Google ColumnLimit: 88 IndentWidth: 4 AccessModifierOffset: -4 SortIncludes: true ConstructorInitializerIndentWidth: 8 ContinuationIndentWidth: 8 DerivePointerAlignment: false MaxEmptyLinesToKeep: 2 ... To help with automerging, you will need to run this same command with the same formatting rules on your own branch. Then commit those changes, and then finally merged
One feature of clang-format is auto-sorting #includes. This has the side-effect of breaking files that don't properly include headers in a self-contained way.
bonimy
force-pushed
the
clang-format
branch
2 times, most recently
from
04d5627 to
b2f23ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clang-format all source files
All files were formatted with the command at repository root:
find ./ -iname *.h -o -iname *.cpp | xargs clang-format -i.clang-format contents:
To help with automerging, you will need to run this same command with
the same formatting rules on your own branch. Then commit those changes,
and then finally merged