Replace rlwrap with rlfe#230
Draft
alexander-yakushev wants to merge 2 commits intoQuantisan:masterfrom
Draft
Conversation
51f1a00 to
d4ce923
Compare
d4ce923 to
5e8b9f6
Compare
Contributor
Author
|
Drafting this for now. Entrypoint business is a mess 😞. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #229, I discovered the following: the installation of
rlwrapon Debian and Ubuntu pulls ~80 MB of additional packages (python3 and other stuff). That sounds excessive for a mere readline wrapper. Given that, and the fact that rlwrap is bugged in Docker and requires hacks to operate, this is a proposal to replace it with another readline wrapper, rlfe. It has a much slimmer dependency tree and looks simpler. I've verified that it works, supports GNU readline's navigation commands (^A, ^E, etc.), handles ^C dorrectly.Main points:
clojure, is not affected in any way.rlwrapthere before. Also,rlfeis not available on Alpine and will not be installed with these changes. However, the new wrapper script invokesclojuredirectly ifrlfeis not found – a better behavior than what we have now, where callingcljon Alpine fails completely.