chore: Handle empty tokenization in perplexity and allow ad-hoc Advan…#802
Open
arnold-jr wants to merge 1 commit intoQData:masterfrom
Open
chore: Handle empty tokenization in perplexity and allow ad-hoc Advan…#802arnold-jr wants to merge 1 commit intoQData:masterfrom
arnold-jr wants to merge 1 commit intoQData:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…cedAttackMetric
What does this PR do?
Handles empty input_ids when calculating complexity, which gave rise to RuntimeError when using "gpt2" as tokenizer.
Allows for adding metrics to AdvancedAttackMetric with configurable init params.
Summary
This PR cleans up some confusing errors related to perplexity calculation when handling empty inputs. Instead of a RuntimeError, the perplexity calc now throws a ValueError if empty inputs are encountered. It also adds some regression
tests around this error, and makes it possible to pass a different tokenizer to the perplexity calculation in AdvancedAttackMetric.
Additions
Changes
Deletions
Checklist
.rstfile inTextAttack/docs/apidoc.'