Skip to content

Fix hit state manager (2D and 3D) not triggering configuration warning when there is no hit state child #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Lukaswbrr wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

Fix hit state manager (2D and 3D) not triggering configuration warning when there is no hit state child #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/hit/2d/hit_state_manager_2d.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ func _ready() -> void:
func _get_configuration_warnings() -> PackedStringArray:
var warnings: PackedStringArray = []

if get_children().any(func(node): node is FrayHitState2D):
if not get_children().any(func(node): return node is FrayHitState2D):
warnings.append("This node has no hit states so there is nothing to manage. Consider adding a FrayHitState2D as a child.")

return warnings
Expand Down
2 changes: 1 addition & 1 deletion src/hit/3d/hit_state_manager_3d.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ func _ready() -> void:
func _get_configuration_warnings() -> PackedStringArray:
var warnings: PackedStringArray = []

if get_children().any(func(node): node is FrayHitState3D):
if not get_children().any(func(node): return node is FrayHitState3D):
warnings.append("This node has no hit states so there is nothing to manage. Consider adding a FrayHitState3D as a child.")

return warnings
Expand Down