Open
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #555 +/- ##
===========================================
- Coverage 96.49% 83.70% -12.79%
===========================================
Files 67 67
Lines 14663 14708 +45
===========================================
- Hits 14149 12312 -1837
- Misses 514 2396 +1882 |
Collaborator
|
I believe that your implementation is correct, i am not sure how authors handle the bias in |
Collaborator
Author
|
will do. iI have students looking into this. Will come ack to the PR after. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
This is a first shot for intializing empirical sinkhorn but the computational gain is not very clear on tests I did locally.
The following code
give sthe following output
Quite far from the computational gains in the paper. Will investigate it more.
Motivation and context / Related issue
How has this been tested (if it applies)
PR checklist