WIP: ENH: enable complex dtype support unconditionally#790
Draft
rgommers wants to merge 1 commit intoPyWavelets:mainfrom
Draft
WIP: ENH: enable complex dtype support unconditionally#790rgommers wants to merge 1 commit intoPyWavelets:mainfrom
rgommers wants to merge 1 commit intoPyWavelets:mainfrom
Conversation
This also gets rid of usage of the deprecated IF macro in Cython code, which resolves a bunch of build warnings.
rgommers
force-pushed
the
complex-everywhere
branch
from
cc90ef8 to
5fb8959
Compare
Collaborator
|
Thanks, @rgommers! |
Member
Author
|
No we don’t want to switch. I know how to make the code MSVC-compatible (Sent from my iPhone)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also gets rid of usage of the deprecated IF macro in Cython code, which resolves a bunch of build warnings.
(won't work on Windows yet, just need to run CI right now to see all the failures)