Include .measure results in Analysis with ngspice-shared#347
Open
infinitymdm wants to merge 4 commits intoPySpice-org:masterfrom
Open
Include .measure results in Analysis with ngspice-shared#347infinitymdm wants to merge 4 commits intoPySpice-org:masterfrom
infinitymdm wants to merge 4 commits intoPySpice-org:masterfrom
Conversation
|
Is this different than #160 ? |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #346
This PR allows PySpice to parse .measure results out of ngspice
runoutput and attach them to Analysis objects when using thengspice-sharedsimulation backend.The code changes should be fairly straightforward - just fetch the results of a
.measdirective from the response to ngspiceruncontrol directives, then pass the measurements up to the Analysis object.