Fix for issue #68: decode key before list_objects#93
Open
ChinnoDog wants to merge 1 commit intoPyFilesystem:masterfrom
Open
Fix for issue #68: decode key before list_objects#93ChinnoDog wants to merge 1 commit intoPyFilesystem:masterfrom
ChinnoDog wants to merge 1 commit intoPyFilesystem:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When listing directory contents the parent directory is enumerated and then metadata is obtained for each child object. The keys in the parent directory are URL encoded. These need to be decoded before obtaining the metadata because boto3 will URL encode them again, resulting in a double encoding.
This issue is easy to test by using scandir to obtain contents of a directory that contain file names with characters that will be URL encoded, such as spaces.