Update test compat with pyftpdlib>=1.5.10#591
Closed
mweinelt wants to merge 1 commit intoPyFilesystem:masterfrom
Closed
Update test compat with pyftpdlib>=1.5.10#591mweinelt wants to merge 1 commit intoPyFilesystem:masterfrom
mweinelt wants to merge 1 commit intoPyFilesystem:masterfrom
Conversation
4 tasks
musicinmybrain
added a commit
to musicinmybrain/pyfilesystem2
that referenced
this pull request
Jun 14, 2025
Inspired by @mweinelt via PyFilesystem#591.
4 tasks
|
This seems to be on the right track, but doesn’t seem quite right at the moment. It looks like Also, there is another use of pyfilesystem2/tests/test_ftpfs.py Lines 331 to 347 in 77a8562 I used this PR as inspiration for #595. |
Author
|
Back then I applied a substitution downstream, so in practice I arrived at the same result as #595, and missed that it touched two tests. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
The pyftpdlib library in version 1.5.10 renamed the
ThreadedTestFTPdtoFtpdThreadWrapper. I've updated that reference and ran the tests. I also updated the version requirement to my best knowledge.