Open
Conversation
* Don't allow files/dirs to be created inside MountFS's internal MemoryFS * Change MountFS's .mounts attribute to a dict instead of a list of tuples * Add a MountFS.unmount method * Add associated unit-tests
althonos
requested changes
Sep 24, 2021
| self.auto_close = auto_close | ||
| self.default_fs = MemoryFS() # type: FS | ||
| self.mounts = [] # type: MutableSequence[Tuple[Text, FS]] | ||
| self.mounts = {} # type: Dict[Text, FS] |
Member
There was a problem hiding this comment.
I think the reason a list was in use here was to preserve ordering of mounted files. Sure, a dict is fine for newer Python versions but I'd think this would change behaviour on Python 2.7. I think using collections.OrderedDict would work instead (and we can drop that when we move the code to PyFilesystem3).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
Addresses issues outlined #486
It's a long time since I've done any PyFilesystem development, so this should should be considered "WIP code", comments welcome... (e.g. I'm not sure if the
unmountmethod is actually useful?)This should be reviewed with care as the "bugfixes" this includes (the first two bullet-points above) subtly change the API of MountFS.