Implement proper symlink support in ReadTarFS#426
Open
Conversation
1f8a574 to
298b90b
Compare
298b90b to
8a07ecd
Compare
Member
Author
|
Moving this to milestone |
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
The current version of
ReadTarFSdoes not support symlinks properly where Tar files do. This PR changes the following:OSFSlike behaviour forInfoInfo.is_dirisTruefor symlinks that map to existing directories.ReadTarFS.isdir(path)returns True ifpathis a symlink that maps to an existing directory.ReadTarFS.isfile(path)returns True if thepathis a symlink that maps to an existing file.ReadTarFs.islink(path)return True if thepathis a symlink (that can also be dangling).Transparent handling of symlinks
ReadTarFS.openbin(path)also works ifpathis a symlink that maps to an existing file.ReadTarFS.listdir(path)also works ifpathis a symlink that maps to an existing file.Closes #409 and partially addresses #425.