add options for several IO operation#362
Open
tzing wants to merge 11 commits intoPyFilesystem:masterfrom
tzing:changes/add-options
Open
add options for several IO operation#362tzing wants to merge 11 commits intoPyFilesystem:masterfrom tzing:changes/add-options
tzing wants to merge 11 commits intoPyFilesystem:masterfrom
tzing:changes/add-options
Conversation
it seems no extra parameters are required for `iotools.make_stream`, and the description for `options` is 'arguments for the filesystem'. so I guess it was misplaced.
lurch
reviewed
Dec 6, 2019
Contributor
|
Just an observation, readtext is as readable as read_text. But I guess it is down to historical design decision. |
Contributor
|
And maybe it's worth adding docstrings like this too? |
the syntax error is cause by the trailing comma in func def, which is added by black. pyproject.toml is added for black to announce the target python version related: psf/black#419
tzing
changed the title
Contributor
|
Question for @willmcgugan - looking at https://docs.pyfilesystem.org/en/latest/reference/base.html , should all functions that take @tzing Sorry for potentially opening a can of worms... 😕 Your PR looks great so far IMHO 👍 |
Author
|
ping @willmcgugan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
Pre discuss in #361, this PR add options for
readbytesandreadtextin each class.Also it changes a behavior in
FS.open, I found this when I was investigate if there's any other thing to be changed.It seems no extra parameters are required for
iotools.make_stream, and the description foroptionsis arguments for the filesystem. So I guess it was misplaced and move options foropenbininside the function.