This repository was archived by the owner on Jan 21, 2021. It is now read-only.
Prevent constraint violation on objects with restrictive permissions#338
Open
pantsman0 wants to merge 2 commits intoPowerShellMafia:masterfrom
Open
Prevent constraint violation on objects with restrictive permissions#338pantsman0 wants to merge 2 commits intoPowerShellMafia:masterfrom
pantsman0 wants to merge 2 commits intoPowerShellMafia:masterfrom
Conversation
Restrict access to ADSI object so they're only writting to the ACL. This fixes an issue writting an ACL when you exclusively have `WriteDACL` permission on a object.
Smart quotes in the previous patch caused issue importing the script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change restricts access to ADSI object so they're only writting to the ACL.
This fixes an issue writting an ACL when you exclusively have
WriteDaclpermission on a object.I have run up against this issue in a pentest where it meant I wasn't able to get to DA, but didn't know what was going on. I also came up against it in a HtB machine, so I had time to debug the tool and see what was going on.
This was an issue because if you don't set the security mask to
Dacl, it will attempt to write the whole object back to LDAP instead of just the ACE. If you only haveWriteDaclon the object, this will obviously fail.This change has been tested against a HtB machine, and successfully wrote DCSync privs where the current master failed.