Local repository network connection failure should write warning or error#1924
Draft
Local repository network connection failure should write warning or error#1924
Conversation
anamnavi
requested review from
SydneyhSmith,
adityapatwardhan,
alerickson and
shammu1
as code owners
added 2 commits
January 6, 2026 14:24
… written for Install and FindVersion scenarios as well
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
anamnavi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a local repository is registered that is not available (for example private repository when machine is out of office), then an error is thrown. In the case where multiple repositories were requested to be checked, the error gets swallowed up and the user is not informed about the error. This PR ensures that the error is caught and populated in
ErrorRecordand a warning or error is written.Note: To ensure a fix can be taken into the next release, this PR was broken up. #1926 will be taken first in favor of this PR. This PR will be to ensure only an error or warning is written based on the condition.
PR Summary
PR Context
Resolves #1923
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.