Open
Conversation
added 2 commits
February 4, 2026 13:14
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds MCP (Model Context Protocol) service configuration support to the Portkey Gateway Helm chart. It introduces a new optional service that can be enabled alongside the existing gateway service.
Changes:
- Added
mcpServiceconfiguration block to values.yaml with default settings - Created a new Kubernetes Service resource template for MCP with conditional rendering
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| charts/portkey-gateway/values.yaml | Adds mcpService configuration block with enabled flag, service type, port, and label/annotation options |
| charts/portkey-gateway/templates/gateway/service.yaml | Adds conditional MCP service template that creates a separate Kubernetes service when enabled |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| metadata: | ||
| name: {{ include "portkeyenterprise.fullname" . }}-mcp | ||
| labels: | ||
| {{- include "gateway.labels" . }} |
There was a problem hiding this comment.
The include statement is missing the 'nindent' directive, which will cause incorrect YAML indentation. This should be {{- include "gateway.labels" . | nindent 4 }}.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.