Add pkg-config check for SDL lib and fallback to deprecated sdl2-config#75
Open
kea wants to merge 1 commit intoPonup:masterfrom
Open
Add pkg-config check for SDL lib and fallback to deprecated sdl2-config#75kea wants to merge 1 commit intoPonup:masterfrom
kea wants to merge 1 commit intoPonup:masterfrom
Conversation
kea
force-pushed
the
check-sdl-pkg-config
branch
3 times, most recently
from
4483207 to
0b7cefc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The use of sdl2-config was deprecated here
libsdl-org/SDL#6467
I also moved the main extension C file and header to the project's root directory to permit the extension's build in the
php-src/extdirectory. The is a limitation on the PHP build system that includes only the H file from the root of the extensions.https://github.com/php/php-src/blob/2d883a6ff09bfc588e5d714a392a1f0e89a09926/build/genif.sh#L39