Conversation
hyfi06
approved these changes
Apr 26, 2020
|
|
||
| def get_homeless(d): | ||
| x = dict(d) | ||
| if (x['organization'] != ''): |
There was a problem hiding this comment.
Si tiene una organización no está fijo, por lo que homeless debería ser Flase, no?
| def get_homeless(d): | ||
| x = dict(d) | ||
| if (x['organization'] != ''): | ||
| x.update({'homeless': True}) |
There was a problem hiding this comment.
x['organization'] != '' ya es booleando , pudrías usarlo directamente, sin necesidad del if
| adults = # Using filter, generate a list with all people over 18 years old | ||
| workers = # Using map, generate a new list of people with a key 'homeless' with True or False values, if 'organization' have something or not | ||
| old_people = # Using map, generate a new list of people with a key 'old' with True or False values, if 'age' is greater than 30 or not | ||
| all_python_devs = list(filter(lambda data: data['language'] == 'python', DATA)) |
There was a problem hiding this comment.
Si tu variable es python_devs podrías usar ne la lambda dev en lugar de data, para darle un sentido a los elementos de DATA.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Challenge 07 completed and create two new functions