Deferred Removal of ECS Ids

.github/workflows/build.yml

@@ -19,15 +19,15 @@ jobs:
       matrix:
         config: [Release, Debug]
         os:
-          - windows-2022
+          - windows-2025
           - ubuntu-24.04
           - macos-15
         compiler:
           - clang-18
-          - gcc-14
+          - gcc-15
           - msvc
         exclude:
-          - os: windows-2022
+          - os: windows-2025
             compiler: gcc-14
           - os: ubuntu-24.04
             compiler: msvc
@@ -46,21 +46,21 @@ jobs:
       - name: Setup Cpp
         uses: aminya/setup-cpp@v1
         with:
-          # Skip compiler setup for macos clang-17
-          compiler: ${{ (contains(matrix.os, 'macos') && matrix.compiler == 'clang-17') && '' || matrix.compiler }}
+          # Skip compiler setup for macos clang
+          compiler: ${{ (contains(matrix.os, 'macos') && contains(matrix.compiler, 'clang')) && '' || matrix.compiler }}
           vcvarsall: ${{ contains(matrix.os, 'windows') }}
           cmake: true
           ninja: true
 
-      - name: (MacOS) Install clang-17 through brew
-        if: contains(matrix.os, 'macos') && matrix.compiler == 'clang-17'
+      - name: (MacOS) Install clang through brew
+        if: contains(matrix.os, 'macos') && contains(matrix.compiler, 'clang')
         run: |
-          brew install llvm@17
-          export LLVM_DIR="$(brew --prefix llvm@17)/lib/cmake"
-          echo "CC=$(brew --prefix llvm@17)/bin/clang" >> $GITHUB_ENV
-          echo "CXX=$(brew --prefix llvm@17)/bin/clang++" >> $GITHUB_ENV
-          echo "$(brew --prefix llvm@17)/bin" >> $GITHUB_PATH
-          brew link --overwrite llvm@17
+          brew install llvm@18
+          export LLVM_DIR="$(brew --prefix llvm@18)/lib/cmake"
+          echo "CC=$(brew --prefix llvm@18)/bin/clang" >> $GITHUB_ENV
+          echo "CXX=$(brew --prefix llvm@18)/bin/clang++" >> $GITHUB_ENV
+          echo "$(brew --prefix llvm@18)/bin" >> $GITHUB_PATH
+          brew link --overwrite llvm@18
 
       - name: Cache Build
         uses: actions/cache@v4

Include/Misc/PipeDebug.h

@@ -136,9 +136,9 @@ namespace p
 		TArray<DebugECSInspector> inspectors{1};
 
 		// Updated on tick
-		TArray<const BasePool*> includePools;
-		TArray<const BasePool*> excludePools;
-		TArray<const BasePool*> previewPools;
+		TArray<const IPool*> includePools;
+		TArray<const IPool*> excludePools;
+		TArray<const IPool*> previewPools;
 
 		// Layout
 		bool resetLayout    = true;
@@ -747,7 +747,7 @@ namespace p
 			ImGui::PushStyleCompact();
 			static String poolName;
 			ImGui::PushButtonColor(previewColor);
-			for (const BasePool* previewPool : ecsDbg.previewPools)
+			for (const IPool* previewPool : ecsDbg.previewPools)
 			{
 				if (previewPool && previewPool->Has(id))
 				{
@@ -1008,7 +1008,7 @@ namespace p
 					FindAllIdsWith(ecsDbg.includePools, ids);
 				}
 
-				for (const BasePool* pool : ecsDbg.excludePools)
+				for (const IPool* pool : ecsDbg.excludePools)
 				{
 					ExcludeIdsWithStable(pool, ids, false);
 				}

Include/Pipe/Core/PageBuffer.h

@@ -118,9 +118,10 @@ namespace p
 
 		Type* At(sizet index)
 		{
-			if (Type* page = pages[GetPage(index)])
+			const i32 pageIndex = GetPage(index);
+			if (pageIndex < pages.Size() && pages[pageIndex])
 			{
-				return page + GetOffset(index);
+				return pages[pageIndex] + GetOffset(index);
 			}
 			return nullptr;
 		}

Include/Pipe/Core/Subprocess.h

@@ -7,17 +7,13 @@
 #include "Pipe/Export.h"
 #include "PipeArrays.h"
 
-#include <stdio.h>
-#include <string.h>
-
-
-#if !defined(_MSC_VER)
-	#include <signal.h>
-	#include <spawn.h>
-	#include <stdlib.h>
-	#include <sys/types.h>
-	#include <sys/wait.h>
-	#include <unistd.h>
+// Including PipePlatform.h would be overkill just for this
+#ifndef P_PLATFORM_WINDOWS
+	#if defined(_WIN64) || defined(_WIN32)
+		#define P_PLATFORM_WINDOWS 1
+	#else
+		#define P_PLATFORM_WINDOWS 0
+	#endif
 #endif
 
 
@@ -61,7 +57,7 @@ namespace p
 		FILE* coutFile = nullptr;
 		FILE* cerrFile = nullptr;
 
-#if defined(_MSC_VER)
+#if P_PLATFORM_WINDOWS
 		void* hProcess     = nullptr;
 		void* hStdInput    = nullptr;
 		void* hEventOutput = nullptr;

Include/Pipe/Core/TypeId.h

@@ -105,8 +105,8 @@ namespace p
 	}
 
 
-#pragma region Casteable
-	struct Casteable
+#pragma region Castable
+	struct Castable
 	{
 	private:
 		mutable TypeId typeId;
@@ -126,8 +126,8 @@ namespace p
 	};
 
 	template<typename T>
-	concept IsCasteable = Derived<std::remove_pointer_t<T>, Casteable, false>;
-#pragma endregion Casteable
+	concept IsCastable = Derived<std::remove_pointer_t<T>, Castable, false>;
+#pragma endregion Castable
 }    // namespace p
 
 

Include/Pipe/Extern/utf8.h

@@ -34,13 +34,13 @@ and set it to one of the values used by the __cplusplus predefined macro.
 
 For instance,
     #define UTF_CPP_CPLUSPLUS 199711L
-will cause the UTF-8 CPP library to use only types and language features available in the C++ 98
-standard. Some library features will be disabled.
+will cause the UTF-8 CPP library to use only types and language features available in the C++ 98 standard.
+Some library features will be disabled.
 
 If you leave UTF_CPP_CPLUSPLUS undefined, it will be internally assigned to __cplusplus.
 */
 
-#include "Pipe/Extern/utf8/checked.h"
-#include "Pipe/Extern/utf8/unchecked.h"
+#include "utf8/checked.h"
+#include "utf8/unchecked.h"
 
-#endif    // header guard
+#endif // header guard