Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a configurable --allow-check-failures CLI flag that allows the backup process to continue when validation checks fail, converting fatal errors to warnings while still completing file archiving and MD5 generation.
Changes:
- Added
allow_check_failuresparameter tobackup_fastqfunction with defaultFalse - Refactored three validation checks (file path vs content, file size, and run consistency) to collect results in arrays and conditionally emit warnings instead of raising ValueError
- Added
--allow-check-failuresCLI argument that propagates the setting through to the backup function
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
allow_check_failuresparameter tobackup_fastqwith defaultFalseand propagate a new--allow-check-failuresCLI flag to the function.ValueErrorraises forcheck_fp_vs_content,check_file_size, and run-consistency checks with collected result arrays so failures can be handled conditionally.warnings.warnwhen checks fail andallow_check_failuresis enabled, otherwise preserve the originalValueErrorbehavior.Testing
Codex Task