Handle lane-less Undetermined fastq files#14
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for handling Illumina Undetermined FASTQ files that lack lane information in their filenames, ensuring they can be properly parsed and archived with appropriate lane identifiers.
- Extends FASTQ filename parsing to handle lane-less Undetermined files
- Updates archive logic to rename files with L001 when lane is missing from filename
- Adds comprehensive test coverage for both parsing and backup functionality
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| seqBackupLib/illumina.py | Adds regex pattern for lane-less Undetermined FASTQ files and fallback to header lane info |
| seqBackupLib/backup.py | Updates file path building and archiving to handle lane-less files with proper renaming |
| test/test_illumina.py | Tests parsing of lane-less FASTQ files and archive directory building |
| test/test_backup.py | Tests backup functionality for lane-less files including proper renaming |
Comments suppressed due to low confidence (1)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
pytesthttps://chatgpt.com/codex/tasks/task_e_689dfcb261788323b165309f4c2cb72e