Fix nodeId check for cluster nodes for power report#9367
Open
ALameLlama wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Open
Fix nodeId check for cluster nodes for power report#9367ALameLlama wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
ALameLlama wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
nodeId is out of scope of this loop and is always nil
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
nodeIdis always nil here since nodeId isn't in the scope of the loop. I think this might have been copied from above where we do this:In this loop we have
nodeNamebut I don't think this is the correct thing to use andnode.idseem to be working.Steps taken to verify a working solution:
Link to a build that showcases this PR:
N/A
Before screenshot:
After screenshot:
I guess this is more of a potential performance improvement since it'll be doing less uneeded work.