This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Allow for subprojects that aren't fabric mods#201
Open
kitlith wants to merge 3 commits intoPatchworkMC:1.14.xfrom
Open
Allow for subprojects that aren't fabric mods#201kitlith wants to merge 3 commits intoPatchworkMC:1.14.xfrom
kitlith wants to merge 3 commits intoPatchworkMC:1.14.xfrom
Conversation
kitlith
requested review from
TheGlitch76,
TwilightFlower and
williambl
as code owners
Contributor
Author
|
oh. i guess that means we'll have to rerun the checks after the fabric-loom pr gets merged. oh well. |
Contributor
Author
|
There is one occurance of subprojects and one occurance of allprojects left, but i'm not quite sure what to do with them: |
Contributor
Author
|
fabric-loom now includes the PR, will double check some stuff and re-run checks. |
This was referenced Nov 16, 2020
Closed
Member
|
Leaving this open as a curiosity--I'm planning on having special processors be their own projects, but I may change my mind. |
Contributor
Author
|
fair 'nuff, lmk if you ever want me to rebase or whatever. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is accomplished by moving away from subprojects and allprojects closures to using precompiled script plugins to accomplish the same thing. We can now opt out of the things in subprojects/allprojects by simply not applying the relevant plugin.
loom shareCaches won't quite work (and thus running this build in parallel) until FabricMC/fabric-loom#299 is merged and present in a release of fabric-loom.
(Motivated by wanting to create an annotation processor as a subproject, which is decidedly not a fabric mod.)