Draft
Conversation
Co-authored-by: Warwick Schroeder <warwick.schroeder@particular.net>
Co-authored-by: Warwick Schroeder <warwick.schroeder@particular.net>
…rse Proxy, Direct HTTPS, CORS
…ocumentation in readme
…tance checks with auth.
… as ServicePulse should be the only client using it.
mikeminutillo
force-pushed
the
embed-servicepulse
branch
from
822a49a to
2709ff3
Compare
PhilBastian
approved these changes
Jan 29, 2026
Contributor
PhilBastian
left a comment
PhilBastian
left a comment
There was a problem hiding this comment.
I'm amazed at how many places need to change to get one extra boolean setting in 😓
| if (!instance.AppConfig.AppSettingExists(ServiceControlSettings.EnableEmbeddedServicePulse.Name)) | ||
| { | ||
| var result = await windowManager.ShowYesNoCancelDialog("INPUT REQUIRED - EMBEDDED SERVICEPULSE", | ||
| "ServiceControl can host an embedded version of ServicePulse which allows you to monitor your ServiceControl instance without needing to install ServicePulse separately.", |
Contributor
There was a problem hiding this comment.
Suggested change
| "ServiceControl can host an embedded version of ServicePulse which allows you to monitor your ServiceControl instance without needing to install ServicePulse separately.", | |
| "ServiceControl can host an embedded version of ServicePulse, which allows you to monitor your ServiceControl instance without needing to install ServicePulse separately. For more information, see <insert link here>", |
| { | ||
| var result = await windowManager.ShowYesNoCancelDialog("INPUT REQUIRED - EMBEDDED SERVICEPULSE", | ||
| "ServiceControl can host an embedded version of ServicePulse which allows you to monitor your ServiceControl instance without needing to install ServicePulse separately.", | ||
| "Would you like to enable the embedded ServicePulse for this instance?", |
Contributor
There was a problem hiding this comment.
Nitpicking, but the question doesn't match the answers.
Suggested change
| "Would you like to enable the embedded ServicePulse for this instance?", | |
| "Should an embedded ServicePulse be enabled for this ServiceControl instance?", |
Comment on lines
+127
to
+128
| "Enable Embedded ServicePulse", | ||
| "Do NOT enable Embedded ServicePulse"); |
Contributor
There was a problem hiding this comment.
Suggested change
| "Enable Embedded ServicePulse", | |
| "Do NOT enable Embedded ServicePulse"); | |
| "Enable embedded ServicePulse", | |
| "Do NOT enable embedded ServicePulse"); |
johnsimons
reviewed
Jan 29, 2026
|
|
||
| if (!instance.AppConfig.AppSettingExists(ServiceControlSettings.EnableEmbeddedServicePulse.Name)) | ||
| { | ||
| var result = await windowManager.ShowYesNoCancelDialog("INPUT REQUIRED - EMBEDDED SERVICEPULSE", |
Member
There was a problem hiding this comment.
I don't know if using the word "embedded" means much to other people. Remember this may not be installed by a developer.
Member
There was a problem hiding this comment.
Maybe use "included" or "shipped together"
Member
There was a problem hiding this comment.
@mikeminutillo @PhilBastian here are a few suggestions for you consideration
warwickschroeder
force-pushed
the
genxp-3600-add-authentication
branch
from
57176d8 to
29ef67b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires the output of Particular/ServicePulse#2786