[SPIKE] Host ServicePulse frontend code from ServiceControl#5227
Draft
johnsimons wants to merge 2 commits intomasterfrom
Draft
[SPIKE] Host ServicePulse frontend code from ServiceControl#5227johnsimons wants to merge 2 commits intomasterfrom
johnsimons wants to merge 2 commits intomasterfrom
Conversation
johnsimons
changed the title
johnsimons
changed the title
johnsimons
changed the title
mikeminutillo
approved these changes
Dec 12, 2025
src/ServiceControl/Infrastructure/WebApi/AppConstantsMiddleware.cs
Outdated
Show resolved
Hide resolved
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another spike in the same league as #5189
This spike uses the Particular.PlatformSample.ServicePulse package to extract the web resources from it and serve them as part of ServiceControl ASP.NET Core pipeline.
It also makes
app.constants.jsbe served from the server, so that we can configure things.In this spike, we have added the
embeddedflag toapp.constants.jsso that we can customise ServicePulse UI/X.