Open
Conversation
erikvansebille
requested changes
Feb 6, 2026
Member
erikvansebille
left a comment
erikvansebille
left a comment
There was a problem hiding this comment.
Code changes look good to me; but could you also add some unit-tests so that we don’t unintentionally break this functionality later?
j-atkins
force-pushed
the
problems-report
branch
from
f691a61 to
4ffa080
Compare
for more information, see https://pre-commit.ci
Collaborator
Author
I've added more testing now 👍 |
erikvansebille
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a step to generate a human-readable record of all problems which occurred across the expedition (including their full message), which could be useful to refer back to when students are making their presentations.
Also tidies up some of the
problems_encountereddirectory strucutre.